fix: allow Ctrl+C to copy selected text in Details Pane #17819
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| if (!App.AppModel.IsMainWindowClosed && sender is WindowEx window) | ||
| { | ||
| args.Handled = true; | ||
| args.Handled = false; |
There was a problem hiding this comment.
Bug: Setting args.Handled = false in PropertiesWindow_Closed() allows window destruction, reintroducing known access violations.
Severity: CRITICAL | Confidence: 1.00
🔍 Detailed Analysis
The PropertiesWindow_Closed() event handler is modified to set args.Handled = false. This change allows the properties window object to be destroyed upon closure. This directly reverts a previous workaround implemented to prevent access violations, which were observed when the window was destroyed, particularly for inactive or background windows. The original workaround involved setting args.Handled = true to prevent destruction and instead cache the window, addressing issue #12057.
💡 Suggested Fix
Revert args.Handled = false to args.Handled = true in the PropertiesWindow_Closed() event handler to prevent window destruction and maintain the existing workaround for issue #12057.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: src/Files.App/Utils/Storage/Helpers/FilePropertiesHelpers.cs#L156
Potential issue: The `PropertiesWindow_Closed()` event handler is modified to set
`args.Handled = false`. This change allows the properties window object to be destroyed
upon closure. This directly reverts a previous workaround implemented to prevent access
violations, which were observed when the window was destroyed, particularly for inactive
or background windows. The original workaround involved setting `args.Handled = true` to
prevent destruction and instead cache the window, addressing issue #12057.
Did we get this right? 👍 / 👎 to inform future reviews.
|
@Rahul2322-P thank you for the PR. I'm not seeing how this solves the issue, can you please clarify? |
|
This PR is superseded by #17825 |
2 participants
Fixed the bug where Ctrl+C was copying the file instead of the selected text in the Details Pane.
Changed args.Handled = true to args.Handled = false in OnCopyInvoked().
Now, when a text field is focused, Ctrl+C copies the text as expected.